Skip to content

10.11#49

Merged
LePips merged 7 commits into
jellyfin:mainfrom
JPKribs:10.11
Oct 23, 2025
Merged

10.11#49
LePips merged 7 commits into
jellyfin:mainfrom
JPKribs:10.11

Conversation

@JPKribs
Copy link
Copy Markdown
Member

@JPKribs JPKribs commented Oct 20, 2025

Summary

Swiftfin PR: jellyfin/Swiftfin#1772

Re-generated the SDK on 10.11 OpenAPI spec. Manually revised the patching process that was in place for TaskTriggerType now that TaskTriggerInfoType exists. I've commented it out for now so we have scaffolding for when we eventually have some patch files in the future.

Finally, added all new DOVI to our renaming.

Outstanding Questions

  • SDK generation removes the User Profile Image parameter for maxWidth. Is this expected/alright?
  • Keep commented Patch File work or remove it from the config?

@JPKribs
Copy link
Copy Markdown
Member Author

JPKribs commented Oct 20, 2025

@LePips I've generated this using the Makefile for 10.11. Testing, I don't see anything broken. Of the added lines, please note that 12K of the 12,535 are just the new JSON spec file.

Please let me know if there is anything that needs adjusting! I've started looking at Swiftfin for making changes to get us moved over to this version of the SDK but I wasn't sure if I should wait until after jellyfin/Swiftfin#1752 since that looks like a fairly long change I'd rather not add SDK version complexity to.


Working on migrating Swiftfin to this, it's a clean move without any major issues or changes. The only thing I've found to be weird is the getUserProfileImage is missing the maxWidth now.

Copy link
Copy Markdown
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK generation removes the User Profile Image parameter for maxWidth. Is this expected/alright?

Yes, as the server removed image processing for public images (splashscreen, user image).

Comment thread Plugins/CreateAPI/GeneratePlugin.swift
@LePips LePips merged commit e7bb3b7 into jellyfin:main Oct 23, 2025
@JPKribs JPKribs deleted the 10.11 branch October 23, 2025 21:17
@albarago
Copy link
Copy Markdown

Hello, I'm still facing this issue
image

Is this in the works or is something wrong in my end?

@JPKribs
Copy link
Copy Markdown
Member Author

JPKribs commented Nov 17, 2025

Resolved in 1.4. You can download our TestFlight for our fix in 1.4 now or wait for the final App Store release which is still TBD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants